Better Serializer support + disabled Symfony serializer #7
+2,296
−378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have forked this repo in https://github.com/php-serializers/ivory-serializer-benchmark and created a I invite you to use https://github.com/php-serializers/ivory-serializer-benchmark for benchmarking PHP serializer libraries I have merged some PR from this repo to the fork, but this PR was looking pretty complex. |
|
@goetas I'll try, but currently I don't have much time to do this, so I'll just do it later, if you don't mind |
|
Sure! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I created my own serializer which seems to be 4-5x faster than JMS and Ivory (using json serialization) ... since there is quite a big difference between the mentioned 3 libs and symfony serializer, I disabled the symfony serializer, because it was 100-300x slower then my own serializer and it was quite a pain to wait for the benchmark results.
Is there any other thing I should do before merge? What do you say about these changes?